Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Hide "Leave organization" button for last member with minimum required permissions #4299

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Oct 7, 2024

Description

Resolves ORGS-158

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Oct 7, 2024
Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 0505689

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@panteliselef
Copy link
Member

I know this is still in draft, but i wanted to be proactive here. I know these tests are hard to find so i'm resurfacing them.
Seems like with the changes introduced in this PR we can unskip the test cases

@LauraBeatris
Copy link
Member Author

LauraBeatris commented Oct 8, 2024

I know this is still in draft, but i wanted to be proactive here. I know these tests are hard to find so i'm resurfacing them. Seems like with the changes introduced in this PR we can unskip the test cases

Thanks for bringing that out @panteliselef! I'll make sure to remove those skip blocks 🫡

@LauraBeatris
Copy link
Member Author

FYI I'm holding on this PR since we're introducing a property on FAPI organization membership in order to avoid having to itinerate through all of the memberships data during rendering time here.

@LauraBeatris LauraBeatris changed the title chore(clerk-js): Hide "Leave organization" button for sole admin chore(clerk-js): Hide "Leave organization" button for sole member with minimum permissions Oct 9, 2024
@LauraBeatris LauraBeatris changed the title chore(clerk-js): Hide "Leave organization" button for sole member with minimum permissions chore(clerk-js): Hide "Leave organization" button for sole member with minimum required permissions Oct 9, 2024
@LauraBeatris LauraBeatris changed the title chore(clerk-js): Hide "Leave organization" button for sole member with minimum required permissions chore(clerk-js): Hide "Leave organization" button for last member with minimum required permissions Oct 9, 2024
@LauraBeatris LauraBeatris changed the title chore(clerk-js): Hide "Leave organization" button for last member with minimum required permissions chore(clerk-js): Hide "Leave organization" button for last member with minimum required permissions Oct 9, 2024
@LauraBeatris
Copy link
Member Author

We've decided not to more forward with hiding the leave organization button due to the complexity of performing some checks on FAPI side.

I'll close this PR. We'll come back to this later and revisit priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants