feat(backend): Migrate to vitest #4296
Conversation
🦋 Changeset detectedLatest commit: 01e60b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jacekradko
force-pushed
the
jacek/backend-vitest
branch
from
d33a518 to
c70d74d
Compare
| @@ -88,7 +88,7 @@ export function buildRequest(options: BuildRequestOptions) { | |||
| let res: Response | undefined; | |||
| try { | |||
| if (formData) { | |||
| res = await runtime.fetch(finalUrl.href, { | |||
| res = await (process.env.NODE_ENV === 'test' ? fetch : runtime.fetch)(finalUrl.href, { | |||
There was a problem hiding this comment.
Will need to think about a more ergonomic way of accomplishing this. With the way fetch is handled in the package, msw can't intercept requests without it for now
There was a problem hiding this comment.
@BRKalow Any thoughts on how you would like to move forward here?
There was a problem hiding this comment.
@jacekradko can we try to consolidate into the runtime module? so at least usage of runtime.fetch doesn't need to be aware of the NODE_ENV
| { | ||
| "name": "Debug Vitest", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/scripts/vitest-debug.mjs", | ||
| "args": ["${file}"], | ||
| "cwd": "${workspaceFolder}", | ||
| "console": "integratedTerminal", | ||
| "internalConsoleOptions": "neverOpen", | ||
| "autoAttachChildProcesses": true, | ||
| "smartStep": true, | ||
| "skipFiles": ["<node_internals>/**", "**/node_modules/**"] |
There was a problem hiding this comment.
Added a debug configuration for any vitest spec
jacekradko
force-pushed
the
jacek/backend-vitest
branch
from
52bb50b to
5665e6e
Compare
jacekradko
force-pushed
the
jacek/backend-vitest
branch
from
5f074a9 to
53f6585
Compare
Description
Spiking out
vitesttest runner as a replacement forqunitin@clerk/backend.Changes
vitestrunnermswinstead of mockingfetchRelated: https://linear.app/clerk/issue/SDKI-694/refactor-clerkbackend-to-use-vitest-instead-of-qunit
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change