-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Initialize default role with form controls #4281
Conversation
🦋 Changeset detectedLatest commit: 6a0e07a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7119b0f
to
6e9c3bf
Compare
packages/clerk-js/src/ui/components/OrganizationProfile/InviteMembersForm.tsx
Show resolved
Hide resolved
b5a0fd1
to
6a0e07a
Compare
Hi, thanks for fixing this! I see that How does this reach |
Hi @FranciscoMoretti! We haven't deployed this change to our CDN workers yet, so this is not fully released. For further context, |
@FranciscoMoretti It's deployed now, you will see the latest fix on your app! |
@LauraBeatris thank you so much for the detailed explanation and update! 💯 |
Description
Fixes issue where "Send invitation" button is getting disabled even tho there's a default role loaded:
CleanShot.2024-10-03.at.17.33.17.mp4
The issue relies on the fact that we're overriding the
field.value
property when rendering it, instead of passing it to the form controls state:CleanShot.2024-10-03.at.17.31.11.mp4
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change