Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add <AutoFillPasswordField /> sign in functionality #4275

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Oct 2, 2024

Description

When a user signs in via a password manager, watch for autofill on password input and conditionally show the field vs moving to the verifications step.

Screen.Recording.2024-10-02.at.4.31.20.PM.mov

Closes SDKI-686

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: e5dcdda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter requested a review from a team October 2, 2024 20:31
Copy link
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@alexcarpenter alexcarpenter merged commit 5aeff83 into main Oct 3, 2024
23 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-686-signin-instant-password-functionality branch October 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants