Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Add major version check workflow #4269

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Oct 1, 2024

Description

This PR adds a GHA that checks if there is a major changeset in a PR and if there is one it expects a !allow-major comment to exist from an org member in order to pass.

This is to prevent accidental major bumps of our packages.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@anagstef anagstef self-assigned this Oct 1, 2024
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: f46de13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef marked this pull request as ready for review October 2, 2024 07:24
@anagstef anagstef marked this pull request as draft October 2, 2024 08:56
@anagstef anagstef marked this pull request as ready for review October 2, 2024 09:08
@anagstef anagstef merged commit ec3bb69 into main Oct 2, 2024
23 checks passed
@anagstef anagstef deleted the stefanos/eco-197-add-a-ci-step-that-fails-when-bumping-major-accidentally branch October 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants