Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): Add tests for restricted sign-up mode #4246

Conversation

nikospapcom
Copy link
Member

@nikospapcom nikospapcom commented Sep 30, 2024

Description

In this pr we are adding e2e tests for restricted sign-up mode
The test cases we're adding is:

  • Sign up page renders restricted access component and then click back to sign-in
  • Sign up page with invitation render correctly and sign up

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: d1a747c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcom nikospapcom self-assigned this Sep 30, 2024
@nikospapcom nikospapcom closed this Oct 1, 2024
@nikospapcom nikospapcom reopened this Oct 1, 2024
@nikospapcom nikospapcom marked this pull request as ready for review October 1, 2024 09:23
Copy link
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall looks good 🔥

integration/tests/restricted-mode.test.ts Outdated Show resolved Hide resolved
integration/tests/restricted-mode.test.ts Outdated Show resolved Hide resolved
@nikospapcom nikospapcom force-pushed the nikospap/user-692-add-e2e-tests-in-clerk-js-repo-for-restricted-mode branch from 7db9898 to c9d62db Compare October 1, 2024 09:35
@nikospapcom nikospapcom force-pushed the nikospap/user-692-add-e2e-tests-in-clerk-js-repo-for-restricted-mode branch from c9d62db to d1a747c Compare October 1, 2024 09:35
@nikospapcom nikospapcom merged commit 96ddf11 into main Oct 1, 2024
20 checks passed
@nikospapcom nikospapcom deleted the nikospap/user-692-add-e2e-tests-in-clerk-js-repo-for-restricted-mode branch October 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants