Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clerk-expo now always requires installing expo-local-authentication #3950

Closed
4 tasks done
the-simian opened this issue Aug 13, 2024 · 6 comments
Closed
4 tasks done
Labels
bug Something isn't working expo

Comments

@the-simian
Copy link

Preliminary Checks

Reproduction

N/A

Publishable key

N/A

Description

Documention requires updating:

When using clerk-expo, you must now install expo-local-authentication or it will break on Android, even if you're not using expo-local-authentication

Android Bundling failed 23781ms node_modules/expo-router/entry.js (7369 modules)
Unable to resolve "expo-local-authentication" from "node_modules/@clerk/clerk-expo/dist/hooks/useLocalCredentials/useLocalCredentials.js"

This breaking change was introduced in eb7cfae
on PR: #3663

Link to the related docs page
https://clerk-docs-git-prettier-fixes.clerkpreview.com/quickstarts/expo

Installing expo-local-authentication fixes the issue. This was a breaking change introduced in #3663

Environment

System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (32) x64 13th Gen Intel(R) Core(TM) i9-13900K
    Memory: 54.17 GB / 62.68 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 22.4.0 - ~/.nvm/versions/node/v22.4.0/bin/node
    npm: 10.8.1 - ~/.nvm/versions/node/v22.4.0/bin/npm
    pnpm: 8.15.1 - ~/.local/share/pnpm/pnpm
    bun: 1.1.18 - ~/.bun/bin/bun
@the-simian the-simian added the needs-triage A ticket that needs to be triaged by a team member label Aug 13, 2024
@panteliselef
Copy link
Member

Hey @the-simian Try following the instructions in #3954 and use this snapshot for a quick fix

npm i @clerk/[email protected] --save-exact

@LekoArts LekoArts added bug Something isn't working and removed needs-triage A ticket that needs to be triaged by a team member labels Aug 14, 2024
@LekoArts LekoArts changed the title [docs] clerk-expo now always requires installing expo-local-authentication clerk-expo now always requires installing expo-local-authentication Aug 14, 2024
@LekoArts LekoArts added the expo label Aug 14, 2024
@panteliselef
Copy link
Member

@the-simian did the snapshot fixed the issue for you ?

@the-simian
Copy link
Author

@panteliselef I installed the missing dependency to work past this for the time being, I've not tested the snapshot

@Gustavo-Kuze
Copy link

Hey @the-simian Try following the instructions in #3954 and use this snapshot for a quick fix

npm i @clerk/[email protected] --save-exact

I can confirm this snapshot fixes the issue.

@the-simian
Copy link
Author

This seemed to also work for me, I'll use the snapshot for the time being

@LekoArts
Copy link
Member

LekoArts commented Sep 4, 2024

This has been fixed in @clerk/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working expo
Projects
None yet
Development

No branches or pull requests

4 participants