Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome-extension): Appropriately handle fulfilled, but null, cookie promises #3788

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jul 23, 2024

Description

Depending on certain setups, we were receiving fulfulled, but null, promises. This updates that check.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski self-assigned this Jul 23, 2024
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 6146fa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
Copy link
Member Author

!snapshot

@tmilewski tmilewski marked this pull request as ready for review July 23, 2024 18:29
@tmilewski tmilewski requested a review from royanger July 23, 2024 18:30
@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.0.2-snapshot.v6146fa5
@clerk/chrome-extension 1.1.6-snapshot.v6146fa5
@clerk/clerk-js 5.10.1-snapshot.v6146fa5
@clerk/clerk-expo 1.2.9-snapshot.v6146fa5
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.5.1-snapshot.v6146fa5

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

Copy link
Member

@royanger royanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for customer who reported the issue.

@tmilewski tmilewski merged commit a5d9b48 into main Jul 23, 2024
19 checks passed
@tmilewski tmilewski deleted the tm.fix/ext-cookie-promise-handling branch July 23, 2024 19:35
@dimkl
Copy link
Contributor

dimkl commented Jul 23, 2024

@tmilewski Why do we need this change? What does this affect? Was there an issue that this change fixes?

@tmilewski
Copy link
Member Author

@dimkl It just affects the Chrome Extension. One person was seeing issues with a misconfigured manifest alongside a dev-in-prod scenario, this helps to mitigate that.

BRKalow pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants