-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chrome-extension): Appropriately handle fulfilled, but null, cookie promises #3788
Conversation
🦋 Changeset detectedLatest commit: 6146fa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!snapshot |
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i [email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for customer who reported the issue.
@tmilewski Why do we need this change? What does this affect? Was there an issue that this change fixes? |
@dimkl It just affects the Chrome Extension. One person was seeing issues with a misconfigured manifest alongside a dev-in-prod scenario, this helps to mitigate that. |
Description
Depending on certain setups, we were receiving fulfulled, but null, promises. This updates that check.
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change