feat(ui): Add email link strategy for SignIn #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bce364b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joe-bell
changed the title
alexcarpenter
approved these changes
Jul 15, 2024
| @@ -208,7 +208,7 @@ export function SignInComponentLoaded() { | |||
| <button | |||
| type='button' | |||
| className='text-accent-9 focus-visible:ring-default size-4 rounded-sm outline-none focus-visible:ring-2' | |||
| aria-label='Edit email address' | |||
| aria-label='Start again' | |||
There was a problem hiding this comment.
Are there localized values for these already by chance?
There was a problem hiding this comment.
Not yet! Already created a follow-up ticket to come back to this (and other areas) before we ship!
joe-bell
force-pushed
the
joe-bell/SDKI-72
branch
from
43fcd52 to
80e672e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable
<SignIn.Strategy name='email_link'>with resend functionalityNote
Whilst the UI works as expected, no email will be sent due to the lack of a
redirect_url. This will be tackled in a follow-up ticket once addressed upstreamAdditional Changes
I switched all the
aria-labels for the pencil icon to "Start again" as this felt more appropriate; this might be a good candidate for extraction later. I'll create a follow-up ticket to translate in our polishing milestoneChecklist
npm testruns as expected.npm run buildruns as expected.Type of change