fix(elements): Ensure the input value provided from controlled component persists on changes #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexcarpenter
commented
Jul 12, 2024
Comment on lines
+70
to
+75
| React.useEffect( | ||
| function syncSelectedCountry() { | ||
| setSelectedCountry(countryOptions.find(c => c.iso === iso) || countryOptions[0]); | ||
| }, | ||
| [iso], | ||
| ); |
There was a problem hiding this comment.
Ensures proper country is shown on load
https://linear.app/clerk/issue/SDKI-95/common-phone-number-field-isnt-automatically-localized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue when a elements input is controlled, and ensures the latest value provided is sent to the machine.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change