Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(astro): Move safe id generation to a shared function #3698

Merged

Conversation

wobsoriano
Copy link
Member

Description

This PR tackles ECO-22 and consolidates ID generation with a custom utility function

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: da25f2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano wobsoriano requested a review from panteliselef July 11, 2024 23:02
@wobsoriano wobsoriano marked this pull request as ready for review July 11, 2024 23:02
@LekoArts LekoArts enabled auto-merge (squash) July 12, 2024 11:04
@LekoArts LekoArts merged commit 0937bf6 into main Jul 12, 2024
16 checks passed
@LekoArts LekoArts deleted the rob/eco-22-move-safe-id-generation-to-a-shared-function branch July 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants