feat(ui): Render email or phone number during verification step #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca02d78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
changed the title
alexcarpenter
changed the title
9 tasks
…or-accessing-email-address-and-phone-2
octoper
approved these changes
Jul 11, 2024
| export function SignUpIdentifier({ emailAddress, phoneNumber }: Identifier) { | ||
| const { client } = useClerk(); | ||
| const signUpEmailAddress = client.signUp.emailAddress; | ||
| const { formattedNumberWithCode: signUpPhoneNumber } = parsePhoneString(client.signUp.phoneNumber || ''); |
There was a problem hiding this comment.
❔ Minor thing feel free to ignore, should we consider moving the parsing here inside the if statement below to avoid calling parsePhoneString when there is no phone number?
alexcarpenter
deleted the
alexcarpenter/sdk-1830-add-signup-elements-for-accessing-email-address-and-phone-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<SignUpIdentifier />component to render either the formatted phone number or email address.email_codeverification stepphone_codeverification stephttps://linear.app/clerk/issue/SDK-1830/add-signup-elements-for-accessing-email-address-and-phone-number
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change