Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome-extension): Clear JWT on init, prior to polling #3686

Closed
wants to merge 2 commits into from

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jul 10, 2024

Description

An extension can wind up in a state where it doesn't have the latest JWT. To prevent this, we clear the current JWT and poll for the latest from the origin.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski requested a review from royanger July 10, 2024 17:31
@tmilewski tmilewski self-assigned this Jul 10, 2024
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: b5b62c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.v3195533
@clerk/chrome-extension 1.1.3-snapshot.v3195533
@clerk/clerk-js 5.8.1-snapshot.v3195533
@clerk/clerk-expo 1.2.6-snapshot.v3195533
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/testing 1.1.10-snapshot.v3195533

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@tmilewski tmilewski closed this Jul 22, 2024
@tmilewski tmilewski deleted the tm.fix/chrome-ext-clear-before-poll branch July 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants