-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserProfile component triggers hard navs on Nextjs (and others) #3547
Comments
Are you using the latest version of the nextjs SDK at the moment? We think we fixed this in the latest version, just want to confirm. |
5.1.5 still displays the behaviour for me
Nothing here seems out of place. Feel free to make an account, I will delete it after (and I don't even have a DB so your personal data doesn't go anywhere except clerk). Locally, the project doesn't need any particular setup for reproing. Required env vars are as follows NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=<redacted>
CLERK_SECRET_KEY=<redacted>
NEXT_PUBLIC_CLERK_SIGN_IN_URL="/sign-in"
NEXT_PUBLIC_CLERK_SIGN_UP_URL="/sign-up" |
Hello 👋 In an effort to keep our GitHub issues clean and focused, we close any issues that are awaiting a reproduction after 8 days on inactivity, and it has been 7 days. This issue will be closed tomorrow unless a reproduction is provided. If it takes longer than this to get a reproduction, that's ok, just drop a comment and we will remove the Stale label. How to create a minimal reproduction Thanks for being a part of the Clerk community! 🙏 |
After 8 days without a reproduction being supplied, we are closing this issue. Keep in mind, I'm just a robot, so if I've closed this issue in error, please reply here and my human colleagues will reopen it. Likewise if a reproduction is prepared after it has been closed. |
This isn't a minimal reproduction unfortunately, it's a link to part of an entire built-out app. Our instructions for creating a minimal reproduction linked above should outline how to make this happen! |
@jescalan please reopen https://github.com/arlyon/clerk-hard-nav
Same applies to orgs fwiw |
Hey @arlyon - I just pulled down your reproduction and tested it, and there were no hard navigations performed when switching between profile tabs. Opening the developer console while the navigation is being performed shows dom elements being patched directly, and the network tab shows that there is no hard navigation running. Some follow up questions:
|
Oof thanks for the patience. What I thought was a 'hard nav' was the flicker accompanied with the catchall check in dev mode producing an html request in the network tab when switching pages. In production this does not happen and you are correct it is client-side only. My next request is, then, what I can do to reduce / eliminate the flicker. I take it this issue is that the clerk profile widget is not a react tree and needs to be re-initialized? If that is the case I can definitely live with it and will consider re-implementing it 'natively' down the line. |
Hello 👋 We currently close issues after 40 days of inactivity. It's been 30 days since the last update here. If we missed this issue, please reply here. Otherwise, we'll close this issue in 10 days. As a friendly reminder: The best way to see an issue fixed is to open a pull request. If you're not sure how to do that, please check out our contributing guide. Thanks for being a part of the Clerk community! 🙏 |
Hello again 👋 After 40 days of no activity, we'll close this issue. Keep in mind, I'm just a robot, so if I've closed this issue in error, please reply here and my human colleagues will reopen it. As a friendly reminder: The best way to see an issue fixed is to open a pull request. If you're not sure how to do that, please check out our contributing guide. Thanks for being a part of the Clerk community! 🙏 |
Preliminary Checks
Reproduction
Publishable key
pk_test_cHJvLW9yeXgtMjcuY2xlcmsuYWNjb3VudHMuZGV2JA
Description
It would be nice if the router was able to specialize for frameworks and default to a client side nav in supported cases rather than a hard serverside one. This seems to already be the case for navigation between sign in and sign up.
Steps to reproduce:
Expected behavior:
I am using nextjs, so it would be nice if this leveraged the framework to make the navigation seamless.
Actual behavior:
A hard nav.
Environment
The text was updated successfully, but these errors were encountered: