Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clerk-js): Add dev mode notice to components #3511

Merged
merged 11 commits into from
Jul 31, 2024
Merged

feat(clerk-js): Add dev mode notice to components #3511

merged 11 commits into from
Jul 31, 2024

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Jun 4, 2024 •
edited by octoper
Loading

Description

Add a development mode notice to our components to avoid going to productions with dev keys by accident.

CleanShot 2024-07-25 at 15 30 12@2x

CleanShot 2024-07-12 at 03 22 47@2x

CleanShot 2024-07-25 at 15 31 12@2x

CleanShot 2024-07-31 at 13 08 00@2x

CleanShot 2024-07-31 at 13 08 33@2x

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 79dd3a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/astro Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg
Copy link
Contributor Author

!preview

@desiprisg desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from d0c8cd0 to 2cbdac6 Compare June 4, 2024 10:03
@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Jun 4, 2024 •
edited
Loading

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Jul 31, 2024 10:09 AM

@desiprisg desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 2cbdac6 to 8e9316d Compare June 4, 2024 10:17
@desiprisg
Copy link
Contributor Author

!preview

@anagstef
Copy link
Member

anagstef commented Jun 5, 2024

@desiprisg can we have a screenshot of how this looks like?

@desiprisg
Copy link
Contributor Author

@desiprisg can we have a screenshot of how this looks like?

Adding these! Feel free to check the preview deployment as well!

@desiprisg desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch 3 times, most recently from a6e46ac to 8f84fb9 Compare June 6, 2024 10:50
@nikosdouvlis
Copy link
Member

Hey @desiprisg , whats the status of this one?

@desiprisg
Copy link
Contributor Author

Hey @desiprisg , whats the status of this one?

We were waiting for user button / org switcher designs before merging this one.

@octoper octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 8f84fb9 to 5052798 Compare June 26, 2024 10:52
@octoper
Copy link
Member

octoper commented Jun 26, 2024

!preview

@octoper octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 5052798 to 17d5afa Compare July 1, 2024 19:02
@nikosdouvlis
Copy link
Member

@octoper hey :) is this good to go? if not, do you need help with anything at this point?

@octoper
Copy link
Member

octoper commented Jul 11, 2024

There were no designs for <OrgSwitcher/> and <UserButton/> until yesterday, I will take a look at this today

@octoper octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 17d5afa to 9d79ddb Compare July 11, 2024 22:17
@octoper
Copy link
Member

octoper commented Jul 12, 2024

!preview

@octoper octoper self-assigned this Jul 12, 2024
@nikosdouvlis
Copy link
Member

@PixelJanitor something's up with the GH comments, but here's your preview link: https://javascript-preview-3511.clerkpreview.com/

@alexcarpenter
Copy link
Member

@nikosdouvlis @PixelJanitor needs to ensure his Clerk membership status is set to public for !preview and !snapshot comments to function https://github.com/clerk/javascript/blob/main/docs/PUBLISH.md#previewing-prs

@nikosdouvlis
Copy link
Member

@alexcarpenter that's true, but the comment is missing even though the action I triggered was completed successfully: https://github.com/clerk/javascript/actions/runs/10171336607/job/28132106414

@octoper
Copy link
Member

octoper commented Jul 31, 2024

@nikosdouvlis @alexcarpenter The comment is only posted once and gets updated when !preview deployment is done, also the URL of the preview remains the same

@octoper
Copy link
Member

octoper commented Jul 31, 2024

!preview

@octoper octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 8ce6b64 to 79dd3a9 Compare July 31, 2024 13:34
PixelJanitor
PixelJanitor approved these changes Jul 31, 2024
View reviewed changes
Copy link

@PixelJanitor PixelJanitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a code review approval from me (leaving that to an eng), but a design approval based on a deploy preview review. 👍

@octoper octoper merged commit cf8bf65 into main Jul 31, 2024
18 checks passed
@octoper octoper deleted the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch July 31, 2024 15:32
@clerk-cookie clerk-cookie mentioned this pull request Jul 31, 2024
Merged
brkalow pushed a commit that referenced this pull request Aug 1, 2024
@desiprisg @octoper
@anagstef @brkalow
feat(clerk-js): Add dev mode notice to components (#3511)
e342dbc 
Co-authored-by: Vaggelis Yfantis <[email protected]>
Co-authored-by: Stefanos Anagnostou <[email protected]>
nikosdouvlis added a commit that referenced this pull request Aug 1, 2024
@nikosdouvlis
Revert "feat(clerk-js): Add dev mode notice to components (#3511)"
3e15c08 
This reverts commit cf8bf65.
@octoper octoper restored the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch August 1, 2024 08:48
@octoper octoper mentioned this pull request Aug 1, 2024
Merged
9 tasks
wobsoriano pushed a commit that referenced this pull request Aug 1, 2024
@desiprisg @octoper
@anagstef @wobsoriano
feat(clerk-js): Add dev mode notice to components (#3511)
518a18b 
Co-authored-by: Vaggelis Yfantis <[email protected]>
Co-authored-by: Stefanos Anagnostou <[email protected]>
wobsoriano pushed a commit that referenced this pull request Aug 1, 2024
@nikosdouvlis @wobsoriano
Revert "feat(clerk-js): Add dev mode notice to components (#3511)"
796cd57 
This reverts commit cf8bf65.
octoper added a commit that referenced this pull request Aug 2, 2024
@octoper @desiprisg @anagstef
feat(clerk-js): Add dev mode warning to components (#3511) (#3870)
568186c 
Co-authored-by: George Desipris <[email protected]>
Co-authored-by: Stefanos Anagnostou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagstef anagstef anagstef approved these changes

@octoper octoper octoper left review comments

@alexcarpenter alexcarpenter alexcarpenter left review comments

@PixelJanitor PixelJanitor PixelJanitor approved these changes

@nikosdouvlis nikosdouvlis Awaiting requested review from nikosdouvlis

@panteliselef panteliselef Awaiting requested review from panteliselef

Assignees

@octoper octoper

Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@desiprisg @clerk-cookie @anagstef @nikosdouvlis @octoper @kylemac @PixelJanitor @alexcarpenter