fix(clerk-js): Define priority for strategy passkey when user is missing that first factor #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf61ecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Mar 19, 2024
| identifier: string | null, | ||
| ): SignInFactor | null { | ||
| if (isWebAuthnSupported()) { | ||
| // @ts-ignore |
There was a problem hiding this comment.
This is expected, types have not been added yet, to avoid making them public.
LekoArts
approved these changes
Mar 20, 2024
panteliselef
force-pushed
the
elef/sdk-1532-handle-users-without-passkeys
branch
from
97ea5bf to
cf61ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously a readable UI error would appear to users.
Now we treat them a "passwordless" attempt to sign in so we display the otp factors first.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change