feat(elements): Add temporary useIsLoading hook #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b0d0c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
commented
Feb 7, 2024
packages/elements/src/internals/machines/sign-in/sign-in.machine.ts
Outdated
Show resolved
Hide resolved
24 tasks
tmilewski
requested changes
Feb 14, 2024
| * Caution: This hook is unstable and may disappear in the future. | ||
| * This is a temporary hook until the actual loading API is explored and implemented. | ||
| */ | ||
| export const unstable_useIsLoading = () => { |
There was a problem hiding this comment.
To keep with React hook naming conventions:
Suggested change
| export const unstable_useIsLoading = () => { | |
| export const useIsLoading_unstable = () => { |
|
|
||
| const isGlobalLoading = startLoading || firstFactorLoading || secondFactorLoading; | ||
|
|
||
| return [isGlobalLoading, { start: startLoading, firstFactor: firstFactorLoading, secondFactor: secondFactorLoading }]; |
There was a problem hiding this comment.
Likely a cleaner/clearer way to handle this in the long-run, but cool for now. On concern though is that it's specific to signIn, and lives in the root React hooks. Mind moving it over?
Co-authored-by: Tom Milewski <[email protected]>
tmilewski
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While in #2669 Bryce started implementing a holistic solution, for the Alpha stage we'll opt to providing a temporary
unstable_useIsLoadinghook. Took some bits from #2669 that were useful in any way 👍Once we have thought more about the API for loading states we'll remove this again and tackle the proper solution.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore