fix(clerk-js): Fix neutral alpha shades generation #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b9bbaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview |
|
Hey @octoper, your preview is available.
|
anagstef
force-pushed
the
stefanos/sdk-1307-find-a-solution-for-the-gray-shades
branch
from
3ed0872 to
036aad7
Compare
Previously, we added the base color directly as the 500 shade, which is wrong, because the base color should not be included in the alpha scale.
anagstef
force-pushed
the
stefanos/sdk-1307-find-a-solution-for-the-gray-shades
branch
from
036aad7 to
6b9bbaa
Compare
anagstef
deleted the
stefanos/sdk-1307-find-a-solution-for-the-gray-shades
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in generating alpha shades from a user-provided color.
The value provided for the neutral alpha shades should not be included in the scale.
Before:
Users could provide a single color, a part of the scale, or the whole scale to generate alpha colors. We generated an 50-950 alpha scale based on the 500 shade (or the single color) provided by the user, and then we would set the base color used for generation directly to the shade-500 position. This is problematic, because when user provides the color
black, we end up with a scale that has the black color in the shade-500 position, where the shade-950 was lighter than black.After:
The user will be able to provide only a single color or the whole scale for the
colorNeutralproperty.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore