Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(elements): Refactor code to relevant locations #2513

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jan 8, 2024

Description

  • Adds ~/ TS path prefix
  • Moves React-specific components/router to /react sub-folder
  • Remove unnecessary common strategy file.
  • Update sign-in state matcher to only change when the value changes.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski requested a review from BRKalow January 8, 2024 19:39
@tmilewski tmilewski self-assigned this Jan 8, 2024
Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: fa38425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tmilewski tmilewski added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 0bb524a Jan 9, 2024
7 checks passed
@tmilewski tmilewski deleted the tm.elements/refactor branch January 9, 2024 14:20
@LekoArts LekoArts added this to the @clerk/elements (Alpha) milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants