Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Better align new card structure with old descriptors #2506

Conversation

desiprisg
Copy link
Contributor

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: a1644ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg desiprisg marked this pull request as ready for review January 8, 2024 10:52
@desiprisg
Copy link
Contributor Author

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Jan 8, 2024

Hey @desiprisg, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Jan 08, 2024 06:35 PM

@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch from b2e3a98 to e0a8fdc Compare January 8, 2024 11:58
@anagstef
Copy link
Member

anagstef commented Jan 8, 2024

!preview

@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch from e0a8fdc to 81a54ed Compare January 8, 2024 12:09
@desiprisg
Copy link
Contributor Author

!preview

@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch 2 times, most recently from a4c8583 to 08c42b5 Compare January 8, 2024 18:30
@desiprisg
Copy link
Contributor Author

!preview

@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch from 08c42b5 to 5951b40 Compare January 9, 2024 10:49
@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch from 5951b40 to 637e21f Compare January 9, 2024 11:17
@desiprisg desiprisg force-pushed the george/sdk-1174-better-align-card-descriptors-to-old-structure branch from 637e21f to a1644ea Compare January 9, 2024 16:13
@desiprisg desiprisg enabled auto-merge January 9, 2024 16:13
@desiprisg desiprisg added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 5abb25c Jan 9, 2024
7 checks passed
@desiprisg desiprisg deleted the george/sdk-1174-better-align-card-descriptors-to-old-structure branch January 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants