Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Add new typography on card's header and footer #2307

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

marcelscruz
Copy link
Contributor

Description

Changed the default typography for the title and subtitle on the card, and for the action text on the footer.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Before

Screenshot 2023-12-11 at 14 38 54

After

Screenshot 2023-12-11 at 14 38 33

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: cfbe9e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marcelscruz marcelscruz added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 6db2ad1 Dec 11, 2023
9 checks passed
@marcelscruz marcelscruz deleted the retheme-card-header-typography branch December 11, 2023 18:21
octoper pushed a commit that referenced this pull request Dec 13, 2023
* feat(clerk-js): Add new typography on card's header and footer

* chore(clerk-js): Add destructuring on header components props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants