chore(clerk-js): Cleanup Form related deprecations in ClerkJS #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d7f84a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Nov 27, 2023
| @@ -194,6 +200,7 @@ const Checkbox = ( | |||
| ) => { | |||
| return ( | |||
| <Field.Root {...props}> | |||
| {/*TODO: Create a descriptor for Checkbox wrapper*/} | |||
There was a problem hiding this comment.
@desiprisg @anagstef Shall we do this now ?
panteliselef
commented
Nov 27, 2023
| @@ -234,6 +241,7 @@ const OTPInput = (props: OTPInputProps) => { | |||
| // @ts-ignore | |||
| <Field.Root {...restInputProps}> | |||
| <Field.OTPRoot {...props}> | |||
| {/*TODO: Create a descriptor for OTP wrapper*/} | |||
There was a problem hiding this comment.
@desiprisg @anagstef ditto
dimkl
approved these changes
Nov 27, 2023
panteliselef
commented
Nov 27, 2023
nikosdouvlis
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes any deprecated function, variable, context, hook or component that was marked as deprecated and was part of our internal forms.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore