Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Remove UI dependency from core #2084

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

kostaspt
Copy link
Member

@kostaspt kostaspt commented Nov 8, 2023

Description

Decoupled the core Clerk from UI specific utilities.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@kostaspt kostaspt requested a review from a team as a code owner November 8, 2023 15:53
Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 4baf3a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kostaspt kostaspt force-pushed the kostas/remove-core-dep-to-ui branch from 64c88d9 to 6c6002a Compare November 8, 2023 15:53
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

packages/clerk-js/src/ui/common/EmailLinkVerify.tsx Outdated Show resolved Hide resolved
Decoupled the core Clerk from UI specific utilities.
@kostaspt kostaspt force-pushed the kostas/remove-core-dep-to-ui branch from 6c6002a to 4baf3a0 Compare November 8, 2023 16:20
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having UI depending to core it's fine, having core depending on UI i a no-go.

This is a welcome improvement nevertheless. 🙏

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@nikosdouvlis nikosdouvlis merged commit b265764 into main Nov 9, 2023
6 checks passed
@nikosdouvlis nikosdouvlis deleted the kostas/remove-core-dep-to-ui branch November 9, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants