Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Correct initial ref value for form feedback #1937

Closed
wants to merge 1 commit into from

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Oct 25, 2023

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: 50a41d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg desiprisg changed the base branch from main to main-v4 October 25, 2023 17:16
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a changeset

.changeset/breezy-bikes-grin.md Outdated Show resolved Hide resolved
@desiprisg desiprisg force-pushed the correct_ref_form_feedback_v4 branch from 760add9 to 34a16ef Compare October 25, 2023 17:20
@desiprisg desiprisg self-assigned this Oct 25, 2023
@desiprisg desiprisg requested a review from anagstef October 25, 2023 17:27
@desiprisg desiprisg force-pushed the correct_ref_form_feedback_v4 branch from 34a16ef to d828336 Compare October 25, 2023 17:28
@desiprisg desiprisg closed this Oct 25, 2023
@desiprisg desiprisg reopened this Oct 25, 2023
@desiprisg desiprisg force-pushed the correct_ref_form_feedback_v4 branch from b69b607 to 50a41d1 Compare October 25, 2023 18:43
@dimkl
Copy link
Contributor

dimkl commented Oct 25, 2023

Closing this one as we have pushed the commit in the main-v4

@dimkl dimkl closed this Oct 25, 2023
@dimkl dimkl deleted the correct_ref_form_feedback_v4 branch October 25, 2023 19:12
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants