Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added style for prefers-color-scheme to interstitial head #1935

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

royanger
Copy link
Member

Description

This checks if the user prefers dark color schemes, and then sets the body to black. This could reduce 'flashes of white'.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: minor improvement

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: cfe508d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Minor
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg
Copy link
Contributor

Let's add a changeset here by doing npm run changeset

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper octoper changed the base branch from main to main-v4 October 30, 2023 12:32
@octoper octoper changed the base branch from main-v4 to main October 31, 2023 12:08
This checks if the user prefers dark color schemes, and then sets the body to black. This could reduce 'flashes of white'.
@octoper octoper force-pushed the roy/add-prefers-color-scheme-to-interstitial branch from e2da85d to cfe508d Compare October 31, 2023 12:09
@LekoArts LekoArts added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 8b6b094 Oct 31, 2023
7 checks passed
@LekoArts LekoArts deleted the roy/add-prefers-color-scheme-to-interstitial branch October 31, 2023 12:57
LekoArts pushed a commit that referenced this pull request Oct 31, 2023
* Added style for prefers-color-scheme to interstitial head

This checks if the user prefers dark color schemes, and then sets the body to black. This could reduce 'flashes of white'.

* feat(backend): Added prefers-color-scheme to interstitial

(cherry picked from commit 8b6b094)
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
)

* Added style for prefers-color-scheme to interstitial head

This checks if the user prefers dark color schemes, and then sets the body to black. This could reduce 'flashes of white'.

* feat(backend): Added prefers-color-scheme to interstitial

(cherry picked from commit 8b6b094)

Co-authored-by: Roy Anger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants