-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js): Deprecate experimental captcha from Clerk singleton #1905
Conversation
🦋 Changeset detectedLatest commit: e7efefe The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
instanceType?: InstanceType; | ||
|
||
/** Clerk flag for loading Clerk in a standard browser setup */ | ||
isStandardBrowser?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ isn't this getter always available? Shouldn't we use isStandardBrowser
instead of isStandardBrowser?
?
Controls the default state of the UserButton | ||
*/ | ||
Controls the default state of the UserButton | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
/**
* Controls the default state of the UserButton
*/
Controls the default state of the OrganizationSwitcher | ||
*/ | ||
Controls the default state of the OrganizationSwitcher | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
/**
* Controls the default state of the OrganizationSwitcher
*/
@@ -0,0 +1,22 @@ | |||
import type Clerk from '../core/clerk'; | |||
import createFapiClient from '../core/fapiClient'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☁️ i'm kind of skeptic about having a dependency of core
inside utils
. It may result in a cyclic dependency in the future.
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR deprecates the usage of the experimental captcha getter from Clerk singleton. We still need to retrieve this information for the feature to continue to work, so I have introduced a new util function
retrieveCaptchaInfo
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore