Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Deprecate experimental captcha from Clerk singleton #1905

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Oct 17, 2023

Description

This PR deprecates the usage of the experimental captcha getter from Clerk singleton. We still need to retrieve this information for the feature to continue to work, so I have introduced a new util function retrieveCaptchaInfo

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef panteliselef requested a review from dimkl October 17, 2023 17:48
@panteliselef panteliselef self-assigned this Oct 17, 2023
@panteliselef panteliselef requested a review from a team as a code owner October 17, 2023 17:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: e7efefe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BRKalow BRKalow added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 9ca2157 Oct 17, 2023
11 of 12 checks passed
@BRKalow BRKalow deleted the elef/sdk-817-drop-experimental-captcha branch October 17, 2023 21:47
@clerk-cookie clerk-cookie mentioned this pull request Oct 17, 2023
instanceType?: InstanceType;

/** Clerk flag for loading Clerk in a standard browser setup */
isStandardBrowser?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ isn't this getter always available? Shouldn't we use isStandardBrowser instead of isStandardBrowser??

Controls the default state of the UserButton
*/
Controls the default state of the UserButton
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

  /**
   * Controls the default state of the UserButton
   */

Controls the default state of the OrganizationSwitcher
*/
Controls the default state of the OrganizationSwitcher
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

 /**
   * Controls the default state of the OrganizationSwitcher
   */

@@ -0,0 +1,22 @@
import type Clerk from '../core/clerk';
import createFapiClient from '../core/fapiClient';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☁️ i'm kind of skeptic about having a dependency of core inside utils. It may result in a cyclic dependency in the future.

@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants