chore(clerk-js): Remove custom Alert from invitation page and display error as global #1903
Conversation
🦋 Changeset detectedLatest commit: ee5f7d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| gap={2} | ||
| > | ||
| <Text localizationKey={localizationKeys('formFieldLabel__role')} /> | ||
| {/* @ts-expect-error */} |
There was a problem hiding this comment.
❓ Why are we expecting an error? Can we address it or add a description?
There was a problem hiding this comment.
Added the comments, stuff like that is what i am to solve when refactoring our forms
| @@ -75,8 +72,7 @@ export const InviteMembersForm = (props: InviteMembersFormProps) => { | |||
|
|
|||
| const roleField = useFormControl('role', 'basic_member', { | |||
| options: roles, | |||
| // label: localizationKeys('formFieldLabel__firstName'), | |||
| // placeholder: localizationKeys('formFieldInputPlaceholder__firstName'), | |||
| // TODO: localize this | |||
There was a problem hiding this comment.
What's the level of effort to localize these values? Do we have a task for it?
There was a problem hiding this comment.
The value is already localized, i updated the code to reflect the correct state.
… error as global (pr comments)
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR removes the custom Alert from invitation page and displays it as a global error instead (at the top of the component).
Before
Screen.Recording.2023-10-09.at.8.19.57.PM.mov
After
Screen.Recording.2023-10-17.at.7.34.25.PM.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore