chore(repo): Scoping Turborepo task inputs #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25b5840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24 tasks
BRKalow
reviewed
Oct 17, 2023
tmilewski
force-pushed
the
build/turbo-task-inputs
branch
from
c64e8e6 to
4be2951
Compare
LekoArts
reviewed
Oct 18, 2023
tmilewski
force-pushed
the
build/turbo-task-inputs
branch
from
4be2951 to
201750e
Compare
BRKalow
reviewed
Oct 19, 2023
BRKalow
approved these changes
Oct 19, 2023
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speed up DX by scoping down the Turborepo inputs on particular tasks.
As-is, any changed file in a package results in Turborepo marking that package as altered. That slows down the DX as it requires a task (and, potentially, dependent tasks) to be re-run every time.
This PR ensures that only the relevant files are considered when Turborepo is making that determination.
There are a number of useful cases for this, like speeding up the turnaround time for developers running tasks like
npm run test.The convoluted example below might not seem like much, but it all adds up, especially, when the dependent tasks are further up the dependency graph.
Example:
You're testing a change you made to
@clerk/clerk-sdk-nodedirectly and your editing only your tests.Current
You run
npm run test -- --filter=@clerk/clerk-sdk-node:Because all files are considered for the dependent
buildtask, it's also re-run:@clerk/clerk-sdk-node:build(runs)@clerk/clerk-sdk-node:test(runs)New
You run
npm run test -- --filter=@clerk/clerk-sdk-node:Because only required files are considered for the dependent
build, it isn't re-run:@clerk/clerk-sdk-node:build(cached)@clerk/clerk-sdk-node:test(runs)Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore