-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): Apply deprecation warnings #1777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9ef2a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
changed the title
Apply deprecation warnings backend
chore(backend): Apply deprecation warnings for backend
Sep 25, 2023
dimkl
changed the title
chore(backend): Apply deprecation warnings for backend
chore(backend): Apply deprecation warnings
Sep 25, 2023
LekoArts
approved these changes
Sep 26, 2023
dimkl
force-pushed
the
fix-shared-deps-in-backend
branch
from
September 27, 2023 12:59
6e815d1
to
2d79433
Compare
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 27, 2023 13:07
713d2eb
to
26ada15
Compare
dimkl
force-pushed
the
fix-shared-deps-in-backend
branch
from
September 27, 2023 13:58
2d79433
to
f18819e
Compare
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 28, 2023 12:06
26ada15
to
d4567d7
Compare
dimkl
force-pushed
the
fix-shared-deps-in-backend
branch
from
September 28, 2023 12:10
f18819e
to
8f52000
Compare
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 28, 2023 12:12
d4567d7
to
7598d95
Compare
dimkl
commented
Sep 28, 2023
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 28, 2023 12:18
7598d95
to
7d45e54
Compare
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 28, 2023 12:30
7d45e54
to
69c1c67
Compare
…ated) deprecations
Currently the return value is the response.body `data` or throws a ClerkAPIResponseError error with the response.body `errors`
dimkl
force-pushed
the
apply-deprecation-warnings-backend
branch
from
September 28, 2023 12:36
69c1c67
to
d9ef2a6
Compare
SokratisVidros
approved these changes
Sep 28, 2023
nikosdouvlis
approved these changes
Sep 29, 2023
Merged
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review it per commit
Deprecation warnings added in
@clerk/backend
:clockSkewInSeconds
pkgVersion
picture
/logoUrl
/profileImageUrl
(image related)InterstitialAPI
httpOptions
apiKey
frontendApi
Notes: We cannot show deprecation warnings in console for deprecated type properties (eg
UserJSON.profile_image_url
)TODO:
__unstable_options
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore