Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Apply deprecation warnings #1777

Merged
merged 11 commits into from
Sep 29, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Sep 25, 2023

Description

Review it per commit

Deprecation warnings added in @clerk/backend:

  • backend api return format
  • clockSkewInSeconds
  • pkgVersion
  • picture/logoUrl/profileImageUrl (image related)
  • InterstitialAPI
  • httpOptions
  • apiKey
  • frontendApi

Notes: We cannot show deprecation warnings in console for deprecated type properties (eg UserJSON.profile_image_url)

TODO:

  • Show deprecation warning for __unstable_options

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@dimkl dimkl requested a review from a team as a code owner September 25, 2023 16:50
@dimkl dimkl self-assigned this Sep 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: d9ef2a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/shared Patch
@clerk/clerk-react Patch
@clerk/backend Minor
@clerk/nextjs Patch
@clerk/clerk-js Patch
@clerk/fastify Patch
@clerk/remix Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
gatsby-plugin-clerk Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl changed the title Apply deprecation warnings backend chore(backend): Apply deprecation warnings for backend Sep 25, 2023
@dimkl dimkl changed the title chore(backend): Apply deprecation warnings for backend chore(backend): Apply deprecation warnings Sep 25, 2023
@dimkl dimkl force-pushed the fix-shared-deps-in-backend branch from 6e815d1 to 2d79433 Compare September 27, 2023 12:59
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from 713d2eb to 26ada15 Compare September 27, 2023 13:07
@dimkl dimkl force-pushed the fix-shared-deps-in-backend branch from 2d79433 to f18819e Compare September 27, 2023 13:58
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from 26ada15 to d4567d7 Compare September 28, 2023 12:06
@dimkl dimkl force-pushed the fix-shared-deps-in-backend branch from f18819e to 8f52000 Compare September 28, 2023 12:10
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from d4567d7 to 7598d95 Compare September 28, 2023 12:12
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from 7598d95 to 7d45e54 Compare September 28, 2023 12:18
Base automatically changed from fix-shared-deps-in-backend to main September 28, 2023 12:26
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from 7d45e54 to 69c1c67 Compare September 28, 2023 12:30
@dimkl dimkl force-pushed the apply-deprecation-warnings-backend branch from 69c1c67 to d9ef2a6 Compare September 28, 2023 12:36
@dimkl dimkl added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 214f658 Sep 29, 2023
@dimkl dimkl deleted the apply-deprecation-warnings-backend branch September 29, 2023 12:14
@clerk-cookie clerk-cookie mentioned this pull request Sep 29, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants