chore(clerk-react): Mark setSession as deprecated
#1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
🦋 Changeset detectedLatest commit: 49afc86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
SokratisVidros
approved these changes
Jul 15, 2023
| sessions: undefined; | ||
| /** | ||
| * @deprecated This method is deprecated and will be removed in the future. Use {@link Clerk.setActive} instead | ||
| * Set the current session explicitly. Setting the session to `null` deletes the active session. |
There was a problem hiding this comment.
Suggested change
| * Set the current session explicitly. Setting the session to `null` deletes the active session. | |
| * Set the current session explicitly. Setting the session to `null` unsets the active session and signs out the user. |
nikosdouvlis
approved these changes
Jul 17, 2023
anagstef
approved these changes
Jul 17, 2023
panteliselef
force-pushed
the
elef/deprecate_set_session
branch
from
e1ce68e to
c95529c
Compare
This function was already deprecated but was not marked as such when re-exported from the hooks
panteliselef
force-pushed
the
elef/deprecate_set_session
branch
from
c95529c to
49afc86
Compare
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was already deprecated but was not marked as such when re-exported from the hooks
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.