Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper cropping of LEfSe output SVGs #430

Closed
cleme opened this issue Oct 6, 2022 · 2 comments · May be fixed by #472
Closed

Proper cropping of LEfSe output SVGs #430

cleme opened this issue Oct 6, 2022 · 2 comments · May be fixed by #472

Comments

@cleme
Copy link
Member

cleme commented Oct 6, 2022

Describe the bug
The SVGs generated by LEfSe are often incorrectly cropped and the taxonomy strings are not displayed fully. This is not a MMEDS issue, but a LEfSe issue.

To Reproduce
Open any output SVG from LEfSe in Illustrator or similar. The image contains the full taxonomic string, but the cropping is incorrect.

Screenshots
@htlm can provide screnshot

Solution
The SVG files can be directly edited after they are generated. Cropping info is near the top of the file; it should be easy to calculate new cropping dimensions based on the max length of the taxonomic strings found as differential in LEfSe analysis.

@adamcantor22
Copy link
Member

This solution seems doable, but here's another: when generating the plots there are two options --left_space and --right_space which control the cropping of the SVG. In the past, I've fiddled with these values to get LEfSe to generate plots that don't get cut off. It should not be difficult to determine what these two values should be based on the data in the results (.res) file, which would mean not having to directly modify an image file through code.

@adamcantor22 adamcantor22 modified the milestones: 0.10.0, 0.12.0 Oct 12, 2022
@adamcantor22 adamcantor22 added bug and removed bug labels Apr 5, 2023
@adamcantor22
Copy link
Member

superceded by #457, using R for lefse plotting rather than lefse's built-in plots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants