Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CLDF conversion and check #7

Closed
LinguList opened this issue May 19, 2022 · 8 comments
Closed

Run CLDF conversion and check #7

LinguList opened this issue May 19, 2022 · 8 comments

Comments

@LinguList
Copy link
Collaborator

@MuffinLinwist, what is the status on teh cldf conversion, are there any errors now?

@LinguList
Copy link
Collaborator Author

Should I check from my side?

@MuffinLinwist
Copy link
Collaborator

I have run the command and it gives me this error:
ValueError: tables must have distinct url properties

@MuffinLinwist
Copy link
Collaborator

Yes, please. I didn't get this error the other times I run it.

@LinguList
Copy link
Collaborator Author

Please check now, @MuffinLinwist, I made all necessary changes, and it runs now. Please let me know if there are questions. Basically, the strategy was not correct. It would have been better to check with actual cldf dataset conversions, where you can see the difference between add_component and add_column, but also the namespace was quite a problem here, as columns were re-defined, although these components, like a languagetable, come with predefined columns.

But this is all fixed now, and the code is also smaller ;)

@MuffinLinwist
Copy link
Collaborator

Thanks, @LinguList , for the modifications! The dataset is so much better now. I have one question:

  • It is still not clear to me why adding something as a component or as a column. When I put: data_fnames={"ParameterTable": "parameters.csv", "LanguageTable": "languages.csv"}, and add the LanguageTable as a column, it yields the same result. Why choosing one or another? I thought that components are for data re-used across modules. If that's the case, then why the different coding between the two tables?

@LinguList
Copy link
Collaborator Author

It yields the same results, so you choose whatever you like.

@MuffinLinwist
Copy link
Collaborator

Great :)

@FredericBlum
Copy link
Collaborator

The CLDF conversion runs smoothly and we can close this issue, right? #10 is independent from this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants