Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Generation #3

Closed
p-a-s-c-a-l opened this issue Oct 25, 2018 · 12 comments
Closed

Report Generation #3

p-a-s-c-a-l opened this issue Oct 25, 2018 · 12 comments
Assignees
@p-a-s-c-a-l
Labels
BB: Report Generation Report Generation Building Block enhancement New feature or request on-hold Issue is on-hold and will be addressed later
Milestone
D1.3 CLARITY CSIS v1

Comments

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Oct 25, 2018 •
edited
Loading

Add support for Report Generation. based on angular-screenshot to create a screenshot of the respective diagram DOM Element and send image data to the Drupal REST API.
@p-a-s-c-a-l p-a-s-c-a-l added the enhancement New feature or request label Oct 25, 2018
@p-a-s-c-a-l p-a-s-c-a-l self-assigned this Oct 25, 2018
@p-a-s-c-a-l
Copy link
Member Author

Drop support for angular-screenshot as it supports only Chrome. See weihanchen/angular-screenshot#2

p-a-s-c-a-l added a commit that referenced this issue Oct 29, 2018
@p-a-s-c-a-l
#3 add html2canvas
f891fc6
p-a-s-c-a-l added a commit that referenced this issue Oct 29, 2018
@p-a-s-c-a-l
#3 cleaning up and changing package name
b73ad14
p-a-s-c-a-l added a commit that referenced this issue Oct 29, 2018
@p-a-s-c-a-l
#3 experimental screenshot upload
56dff87
p-a-s-c-a-l added a commit that referenced this issue Oct 30, 2018
@p-a-s-c-a-l
#3 basic file upload implemented
da7f9ab
@p-a-s-c-a-l
Copy link
Member Author

We use html2canvas to generate a screenshot of the map area that should be included in the report and upload the PNG image to Drupal. However, at the moment Files created with REST API are only temporary!

p-a-s-c-a-l added a commit that referenced this issue Oct 30, 2018
@p-a-s-c-a-l
#3 screenshot upload with File Entity Module
cba2c13
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.3 CLARITY CSIS v1 milestone Nov 21, 2018
@p-a-s-c-a-l
Copy link
Member Author

For CSIS v1, the report Viewer could be implemented using pdf.js to show server-side generated report.

@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Dec 5, 2018 •
edited
Loading

JSON:API shall be used for saving screenshots: Allow creation of file entities from binary data

@p-a-s-c-a-l p-a-s-c-a-l mentioned this issue Dec 12, 2018
Closed
@p-a-s-c-a-l p-a-s-c-a-l added the SHOWSTOPPER Feature or bug, that, if not addressed, renders the CSIS essentially useless label Dec 14, 2018
@p-a-s-c-a-l p-a-s-c-a-l mentioned this issue Mar 7, 2019
Closed
p-a-s-c-a-l added a commit that referenced this issue Mar 11, 2019
@p-a-s-c-a-l
#3 use JSON api for uploading screenshots
6d70807
p-a-s-c-a-l added a commit that referenced this issue Mar 11, 2019
@p-a-s-c-a-l
#3 image upload implemented
252d8e9
p-a-s-c-a-l added a commit that referenced this issue Mar 12, 2019
@p-a-s-c-a-l
#3 store reportImage Entity
d3ae693
p-a-s-c-a-l added a commit that referenced this issue Mar 12, 2019
@p-a-s-c-a-l
#3 update gl-step relationships to inlcude report image
93b0b85
p-a-s-c-a-l added a commit that referenced this issue Mar 13, 2019
@p-a-s-c-a-l
#3 add report image to an existing list instead of replacing the whol…
c151cb3 
…e list with a new one
p-a-s-c-a-l added a commit that referenced this issue Mar 13, 2019
@p-a-s-c-a-l
#3 add proper titles and add buttons to all diagram types
68f4cae
@ci-cismet-de
Copy link

Integrated branch 'feature/03-report-generation (68f4cae)' into 'dev (f1b79f5)' -- Build 27

@p-a-s-c-a-l
Copy link
Member Author

done

@p-a-s-c-a-l
Copy link
Member Author

Don't trust URIs in JSON received from Drupal JSON:API: clarity-h2020/docker-drupal#57

p-a-s-c-a-l added a commit that referenced this issue Mar 15, 2019
@p-a-s-c-a-l
#3 implement fix for clarity-h2020/docker-drupal#57
36c695c
p-a-s-c-a-l added a commit that referenced this issue Mar 15, 2019
@p-a-s-c-a-l
#3 report image category uuid set to CSIS taxonomy_term--report_image…
53a33c9 
…_category
p-a-s-c-a-l added a commit that referenced this issue Apr 9, 2019
@p-a-s-c-a-l
#3 update comments
47078ad
@p-a-s-c-a-l
Copy link
Member Author

@p-a-s-c-a-l p-a-s-c-a-l reopened this Jul 9, 2019
@p-a-s-c-a-l p-a-s-c-a-l added the BB: Report Generation Report Generation Building Block label Aug 19, 2019
p-a-s-c-a-l added a commit that referenced this issue Oct 2, 2019
@p-a-s-c-a-l
disable include in report button until #3 is fixed
cc0636e
@p-a-s-c-a-l p-a-s-c-a-l mentioned this issue Oct 7, 2019
Closed
@p-a-s-c-a-l p-a-s-c-a-l added on-hold Issue is on-hold and will be addressed later and removed SHOWSTOPPER Feature or bug, that, if not addressed, renders the CSIS essentially useless labels Oct 11, 2019
@p-a-s-c-a-l
Copy link
Member Author

Might become resolved in clarity-h2020/csis-helpers-module#13

@DenoBeno
Copy link

We have a report generation now. Can this be closed?

@p-a-s-c-a-l
Copy link
Member Author

No, it's still not working with the Scenario Analysis App. See clarity-h2020/csis-helpers-module#9 (comment)

@p-a-s-c-a-l p-a-s-c-a-l mentioned this issue Oct 30, 2019
Closed
@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Oct 30, 2019 •
edited
Loading

Is being addressed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-a-s-c-a-l p-a-s-c-a-l

Labels
BB: Report Generation Report Generation Building Block enhancement New feature or request on-hold Issue is on-hold and will be addressed later
Projects
None yet
Milestone
D1.3 CLARITY CSIS v1
Development

No branches or pull requests
3 participants
@p-a-s-c-a-l @DenoBeno @ci-cismet-de