Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing invalid JSON formatting for nested REST Views #65

Closed
patrickkaleta opened this issue Apr 29, 2019 · 2 comments
Closed

Fixing invalid JSON formatting for nested REST Views #65

patrickkaleta opened this issue Apr 29, 2019 · 2 comments
Assignees
Labels
BB: Marketplace myclimateservice.eu Marketplace enhancement New feature or request on-hold Issue is on-hold and will be addressed later wontfix This will not be worked on

Comments

@patrickkaleta
Copy link
Contributor

Some time ago we discussed the possibility to define REST Views (here), which would allow to provide only the desired fields of a content type and even fields of referenced entities by using nested REST Views (idea was to minimalize number of needed REST calls and the size of the payload). This could now be interesting e.g. for sharing content between CSIS and the marketplace via REST (issue).

Nesting REST Views can be achieved by including a REST view inside another REST view. But the problem was that this nested view wasn't properly formatted (a problem in the Core REST module). Example below shows wrong formatting for field_analysis_context, which is another nested View.
nested-wrong-format


@fgeyer16 found a module, which fixes this bug and creates proper JSON objects with nested REST Views. This module is currently only available in Alpha, but I tested it locally and it seems to be working as expected (even with double-nested Views :-) ).
nested-right-format

@patrickkaleta patrickkaleta added the enhancement New feature or request label Apr 29, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.4 CLARITY CSIS v2 milestone Apr 29, 2019
@p-a-s-c-a-l p-a-s-c-a-l added the BB: Marketplace myclimateservice.eu Marketplace label Apr 30, 2019
@p-a-s-c-a-l
Copy link
Member

Is this module now used / still needed in our public CSIS instance?

@patrickkaleta
Copy link
Contributor Author

It is currently not used nor installed and not needed as long as all external services are ok with making multiple REST calls to get what they want. Personally, I'd like to avoid using it since it's still alpha, not very actively developed and not used on many sites.

@p-a-s-c-a-l p-a-s-c-a-l added the on-hold Issue is on-hold and will be addressed later label Jul 1, 2019
@patrickkaleta patrickkaleta added the wontfix This will not be worked on label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Marketplace myclimateservice.eu Marketplace enhancement New feature or request on-hold Issue is on-hold and will be addressed later wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants