Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTT generation fails with unusual timeUnit keys #37

Closed
keighrim opened this issue Jun 6, 2024 · 0 comments · Fixed by #38
Closed

VTT generation fails with unusual timeUnit keys #37

keighrim opened this issue Jun 6, 2024 · 0 comments · Fixed by #38
Labels
🐛B Something isn't working

Comments

@keighrim
Copy link
Member

keighrim commented Jun 6, 2024

Bug Description

When using MMIF from the latest clams whisper app, the visualizer fails to generate VTT format because the timeUnit key used in the app is millisecond, while the timedelta class expects milliseconds.

We need to "normalize" the timeunit key names, and this can be done using SDK helper. However, current implementation of the normalization scheme is using singular millisecond (unfirtunately) and wonder what's the best way to address this bug.

https://github.com/clamsproject/mmif-python/blob/262015bca12bf82a49c50923946e392f8e66d710/mmif/utils/timeunit_helper.py#L5-L22

Reproduction steps

Input whisper output MMIF to the mmif-viz

Expected behavior

No response

Log output

No response

Screenshots

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛B Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant