Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New content styles are not organized compared to the previous one #17759

Open
pomek opened this issue Jan 16, 2025 · 0 comments
Open

New content styles are not organized compared to the previous one #17759

pomek opened this issue Jan 16, 2025 · 0 comments
Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Jan 16, 2025

📝 Provide detailed reproduction steps (if any)

Let's use the following content styles as an example: https://ckeditor.com/docs/ckeditor5/44.1.0/getting-started/legacy/advanced/content-styles.html

Its structure is presented as follows:

  • Header
    /*
     * CKEditor 5 (v44.1.0) content styles.
     * Generated on Tue, 07 Jan 2025 11:59:17 GMT.
     * For more information, check out https://ckeditor.com/docs/ckeditor5/latest/installation/legacy/advanced/content-styles.html
     */
  • Variable definitions
    :root {
      /* ... */
    }
  • Selector definitions
    .ck-content ... {
      /* ... */
    }
  • At-rule definitions
    @media ... {
      /* ... */
    }

Then, let's see how the new content styles look. Example: https://cdn.ckeditor.com/ckeditor5/44.1.0/ckeditor5-content.css

Random thoughts

  • I would expect that variables are merged and, perhaps, at-rules grouped in a single place. As for the latter, we need to verify if it does not change its semantics.
  • Let's update a license header to include the documentation URL. This change does not change much but gives a user a hint as to why it is used.
  • The old content styles are not complete. They lack premium features styles (https://cdn.ckeditor.com/ckeditor5-premium-features/44.1.0/ckeditor5-premium-features-content.css).
@pomek pomek added squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant