Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of getSelectedBlocks #17629

Closed
filipsobol opened this issue Dec 11, 2024 · 0 comments · Fixed by #17582
Closed

Improve performance of getSelectedBlocks #17629

filipsobol opened this issue Dec 11, 2024 · 0 comments · Fixed by #17582
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 82

Comments

@filipsobol
Copy link
Member

One of the features of the getSelectedBlocks method is that it doesn't return children of the block elements. However, we currently still iterate over them, which adds unnecessary overhead.

We should update the implementation so that we jump over these child elements, straight to the end of the block element.
@filipsobol filipsobol added the type:improvement This issue reports a possible enhancement of an existing feature. label Dec 11, 2024
@filipsobol filipsobol mentioned this issue Dec 11, 2024
Merged
scofalik pushed a commit that referenced this issue Dec 19, 2024
@filipsobol
Improve performance of getSelectedBlocks (#17582)
2a114f4 
Other (engine): Improve performance of `Selection#getSelectedBlocks` when selection contains block elements with many blocks inside (e.g. table). Closes #17629.
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Dec 19, 2024
@CKEditorBot CKEditorBot mentioned this issue Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 82
Development

Successfully merging a pull request may close this issue.

Improve performance of getSelectedBlocks ckeditor/ckeditor5
2 participants
@filipsobol @CKEditorBot