Fix django versions in test matrix (#18)

* try to fix which versions of django are used during tests... * label django test step better * tweak label again.. test if requirements change is "taking" * replace requirements right as it's used, lost between steps? * cat requirements... * make sed write in place * try reducing drf so it works with django 1.11 * remove cruft, she workin!
ckc-org · Apr 8, 2021 · 553e879 · 553e879
1 parent 87792b0
commit 553e879
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
@@ -19,9 +19,6 @@ jobs:
       uses: actions/setup-python@v1
       with:
         python-version: ${{ matrix.python-version }}
-    - name: Set up Django ${{ matrix.django-version }}
-      run: |
-        sed 's/Django==.*/Django==${{ matrix.django-version }}/' requirements.txt
     - name: Cache pip
       uses: actions/cache@v1
       with:
@@ -33,7 +30,8 @@ jobs:
           ${{ runner.os }}-
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip
+        echo "Django version set to '${{ matrix.django-version }}' in requirements.txt"
+        sed -i 's/Django==.*/Django${{ matrix.django-version }}/' requirements.txt
         pip install -r requirements.txt
     - name: Lint with flake8
       run: |

diff --git a/requirements.txt b/requirements.txt
@@ -3,7 +3,7 @@ twine==3.1.1
 
 # django stuff
 Django==3.1.8
-djangorestframework==3.12.2
+djangorestframework==3.11.2
 
 # tests
 pytest==5.4.1