Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): added unknown | rejected to TxStatus #558

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Sep 27, 2023

Description

Make unknown and rejected be available in TransactionStatus

https://github.com/nervosnetwork/ckb/blob/922516e967df45c08ce4a62f4c3f2fd8db88d745/util/jsonrpc-types/src/blockchain.rs#L580-L583

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Sep 27, 2023 8:56am

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #558 (3fea672) into ckb2023 (72bca3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           ckb2023     #558   +/-   ##
========================================
  Coverage    86.54%   86.54%           
========================================
  Files          115      115           
  Lines        23338    23338           
  Branches      2330     2330           
========================================
  Hits         20198    20198           
  Misses        3098     3098           
  Partials        42       42           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bca3f...3fea672. Read the comment docs.

@homura homura requested a review from zhangyouxin September 27, 2023 11:03
@homura homura merged commit 0b9b247 into ckb2023 Sep 27, 2023
8 checks passed
@homura homura deleted the ckb2023-tx-status branch September 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants