Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we integrate spotify with Android #203

Open
gustavoggs opened this issue Jun 20, 2022 · 1 comment
Open

Change how we integrate spotify with Android #203

gustavoggs opened this issue Jun 20, 2022 · 1 comment

Comments

@gustavoggs
Copy link
Contributor

Hey @cjam I was doing some tests and I believe that we should move how we do the android integration. We should move the dependency to be direct from auth library that Spotify now releases using maven. The other point is that other Spotify libs like the Flutter one you need to direct add the aar yourself, and I think we should do the same path.

I will send a PR with those ideas and we can discuss on top of it.

@cjam
Copy link
Owner

cjam commented Jul 8, 2022

Sorry for the delayed response. Interesting thoughts. My goal initially was to try and keep the library as consistent across iOS and Android. I believe iOS includes all of the auth pieces and Android has two separate libraries. But, open to discussion on it for sure. Looking at a PR / code might help see the impact of a change like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants