Crash details: crash injury widgets #1611
Open
+95
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnclary
requested review from
frankhereford,
mateoclarke,
chiaberry,
tillyw,
mddilley and
roseeichelmann
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
This creates the basic working injury widgets, taking inspo from the ACC designs. I kept styling super simple: black badges if there are
0injuries, primary (blue) badges if there are injuries. I also played around with only showing badges that had a non-zero value, which I kinda liked but didn't want to overthink this feature.Feedback on design is welcome, and I'll plan on opening a follow-up issue to further refine the look and feel of the badges and the crash header in general.
Testing
Navigate to various crashes and check that the badges are rendering correctly. This would be easier to test if we had the people records on the screen, but that won't happen until we do cityofaustin/atd-data-tech#19965.
Ship list
mainbranch