Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI arguments are partially working after some changes #3015

Open
E85Addict opened this issue Dec 18, 2024 · 1 comment
Open

CLI arguments are partially working after some changes #3015

E85Addict opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
bug triage Needs a preliminary assessment to determine the urgency and required action

Comments

@E85Addict
Copy link

What happened?

After Commit ebdb92d CLI arguments work fine when specified directly to the exe as intended with both -pure_* and -b****, but it has broken the internet shortcut side of things that use to work completely fine. For example using the internet shortcut like fivem://connect/******?-b3095?-pure_2 before the changes in this commit were made worked completely fine, and now pure mode arguments work with no issues, but the build parsing/argument seems to be broken. No matter what combination and position I attempt to use it will not launch the correct build like when using the exe directly. This is a bit of a problem because many FiveM servers use the internet shortcut for joining servers especially those that have implemented a website queue and it causes one to lose time to relaunching the game to the correct build and losing queue position.

Expected result

Launch the correct build using the internet shortcut as well

Reproduction steps

Make sure that the default build in the CitizenFX.ini is different then what you're trying to connect to.
Make 2 shortcuts one using the exe with cli arguments i.e. fivem.exe -b3095 -pure_2 and one using fivem://connect/******?-b3095?-pure_2
Test them both and one will launch the correct build and one won't.

Importancy

Slight inconvenience

Area(s)

FiveM

Specific version(s)

Latest FiveM version.

Additional information

No response

@E85Addict E85Addict added bug triage Needs a preliminary assessment to determine the urgency and required action labels Dec 18, 2024
prikolium-cfx pushed a commit that referenced this issue Dec 25, 2024
Followup fix for:
ebdb92d

Reported in: #3015

After changing the build flag parsing startegy, build flag in internet
shortcut started to get ignored. This is because we replaced general
search through the CLI string with exact arcgument match.

Parse internet stortcut flags and append the build flag as a separate
argument to CLI. If at some point we decide to refactor parsing for all
CLI flags (not just build and pure mode) - we should extract those flags
from internet shortcut string as well.
@E85Addict
Copy link
Author

Commit c8c2815 has fixed and corrected the issue in the latest canary build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

No branches or pull requests

2 participants