Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find cleaner way to override default ports published by our Dockerized postfix #42

Open
1 task
dav3r opened this issue Apr 23, 2021 · 1 comment
Open
1 task

Find cleaner way to override default ports published by our Dockerized postfix #42

dav3r opened this issue Apr 23, 2021 · 1 comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@dav3r
Copy link
Member

dav3r commented Apr 23, 2021

💡 Summary

Find a cleaner mechanism for overriding the default ports published by our Dockerized postfix than what was done in #39.

Motivation and context

Our current solution involves a nasty regex which is much more fragile than we would prefer.

Implementation notes

Some potential ideas and options were discussed here.

Acceptance criteria

  • The regex has been replaced by a solution that brings joy to all who gaze upon its majestic beauty.
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Apr 23, 2021
@dav3r dav3r mentioned this issue Apr 23, 2021
Merged
11 tasks
dav3r added a commit that referenced this issue Apr 23, 2021
@dav3r
Add a comment mentioning #42
a305491
@mcdonnnj
Copy link
Member

Another option we could look at is yq so we wouldn't have to translate to and from JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dav3r @mcdonnnj