Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixtures to remove hardcoded organization names #3394

Open
1 task
erinysong opened this issue Jan 23, 2025 · 0 comments
Open
1 task

Update fixtures to remove hardcoded organization names #3394

erinysong opened this issue Jan 23, 2025 · 0 comments
Labels
bug Something that isn't working as intended dev issue is for the dev team housekeeping

Comments

@erinysong
Copy link
Contributor

erinysong commented Jan 23, 2025

Issue description

fixtures_requests.py still hardcodes a string organization_name for our created Domain Requests. Now that organization name is tied to Portfolios, this leads to some some fixtures Domain Requests' organization names being incorrect.

Domain Requests created within a Portfolio still have the organization name as a hardcoded value from fixtures_requests.py (eg "Example - Withdrawn") instead of the actual portfolio's organization name. This generally gets corrected when assigning an organization name to a Domain Request on the UI, but in the edge case we assign a suborganization, instead of an organization, to a Domain Request the error persists.

Acceptance criteria

  • Update fixtures so that Domain Requests' organizations reflect the portfolio they are assigned to in fixtures.

Additional context

No response

Links to other issues

No response

@erinysong erinysong added dev issue is for the dev team bug Something that isn't working as intended labels Jan 23, 2025
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev issue is for the dev team housekeeping
Projects
Status: 🎯 Ready
Development

No branches or pull requests

2 participants