Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Send email when someone is invited to a portfolio #3019

Open
8 of 9 tasks
Katherine-Osos opened this issue Nov 1, 2024 · 3 comments · May be fixed by #3252
Open
8 of 9 tasks

Dev: Send email when someone is invited to a portfolio #3019

Katherine-Osos opened this issue Nov 1, 2024 · 3 comments · May be fixed by #3252
Assignees
Labels
dev issue is for the dev team Feature: 🏢 Org Model

Comments

@Katherine-Osos
Copy link
Contributor

Katherine-Osos commented Nov 1, 2024

Story

As someone who is invited to a portfolio
I want the system to send me an email notification
so that I know when I've been invited.

Acceptance Criteria

Send emails:

  • When someone is invited to a portfolio via the registrar, send an email notification to that user. Content for that email can be found in this document.
  • When someone is invited to a portfolio via Django admin, send that same email notification to the user IF the user was added thru the "Portfolio invitations" table.
    • Do not send an email if the user was added thru the "User portfolio permissions" table
  • If someone is added to a domain that's part of a portfolio—but the invited user isn't a member of that portfolio yet—they should receive this portfolio invitation AND a domain invitation.

Add static messaging in Django:

  • Add a static message to the top of the "Add portfolio invitation" page that reads: "If you add someone to a portfolio here, it will trigger an invitation email when you click "save." If you don't want to trigger an email, use the User portfolio permissions table instead."
    • Link to the "User portfolio permissions" table in that message.
  • Add a static message to the top of the "Add user portfolio permissions" page that reads: "If you add someone to a portfolio here, it will not trigger an invitation email. To trigger an email, use the Portfolio invitations table instead."
    • Link to the "Portfolio invitations" table in that message.
  • Use slim blue alert, placed right below the heading on the "add" page for those tables.

Additional Context

Design the portfolio invitation email notifications so that they are not tightly coupled to a view, but rather reusable.
Probably best to do here: Refactor the user domain invitation email notifications so that they are not tightly coupled to a view, but rather reusable (match the portfolio invitation pattern) - this will be helpful for all follow-on email notification tickets.

These considerations add scope to the ticket and that warrants a repointing to 5 cc @lizpearl @abroddrick

Issue Links

@h-m-f-t
Copy link
Member

h-m-f-t commented Nov 4, 2024

@Katherine-Osos, can you say a bit more about the second A/C? I'm having a hard time parsing.

This one feels dependent on what our permission model will be, which we don't quite have settled yet. Marking as refinement.

@h-m-f-t h-m-f-t moved this from 👶 New to 🖌 Design Parking Lot in .gov Product Board Nov 4, 2024
@Katherine-Osos
Copy link
Contributor Author

@h-m-f-t Sure. Someone could be invited to a domain directly from the "Domain Mangers" page. And if that domain is part of a portfolio—but the invited user isn't a member of that portfolio yet—then we'll need to send them an invitation to the portfolio as well as an email to manage the domain.

@h-m-f-t
Copy link
Member

h-m-f-t commented Nov 4, 2024

Got it. Maybe it's the ellipses I'm having a hard time with?

@katypies katypies moved this from 🖌 Design Parking Lot to 🍦 Backlog in .gov Product Board Nov 25, 2024
@lizpearl lizpearl moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Dec 5, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Dec 18, 2024
@rachidatecs rachidatecs moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Dec 18, 2024
@dave-kennedy-ecs dave-kennedy-ecs linked a pull request Dec 19, 2024 that will close this issue
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

5 participants