Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio member domains list missing domain invites for existing members #3228

Closed
rachidatecs opened this issue Dec 16, 2024 · 1 comment · Fixed by #3304
Closed

Portfolio member domains list missing domain invites for existing members #3228

rachidatecs opened this issue Dec 16, 2024 · 1 comment · Fixed by #3304
Assignees
Labels
bug Something that isn't working as intended dev issue is for the dev team

Comments

@rachidatecs
Copy link
Contributor

rachidatecs commented Dec 16, 2024

Current Behavior

The list of domains on portfolio domains management pages gets different lists for members and an invites.

If it's an invite (ie email), we retrieve the domains from the domain invitations that intersect the email and portfolio.

if it's a member (ie User), we get the domains from the user domain roles that intersect the user and the portfolio. In this case, we are missing any potential domains that user is invited to.

Expected Behavior

The domain list for a member should include any domains that member is invited to.

Steps to Reproduce

  1. Go to Django admin domain invitation table
  2. Add a domain invite to an existing portfolio User.
  3. Check the domains list for that user.
  4. It does not include the domain added through the invite.

Environment

No response

Additional Context

Suggested solution:
When going to the Domain assignment tab, if the user is an existing member, then we retrieve any “invited” domain invitations and generate the user domain roles. This is done prior to getting all user domain roles for the page, thus when we query for user domain roles we should then have all domains this person can manage.

Issue Links

No response

@rachidatecs rachidatecs added the bug Something that isn't working as intended label Dec 16, 2024
@rachidatecs rachidatecs changed the title Portfolio member domains list does not include invited domains Portfolio member domains list missing domain invites for existing members Dec 16, 2024
@lizpearl lizpearl moved this from 👶 New to ⚙ Dev Parking Lot in .gov Product Board Dec 17, 2024
@lizpearl lizpearl moved this from ⚙ Dev Parking Lot to 🍦 Backlog in .gov Product Board Jan 3, 2025
@lizpearl lizpearl added the dev issue is for the dev team label Jan 3, 2025
@lizpearl lizpearl moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Jan 3, 2025
@lizpearl lizpearl moved this from 🎯 Ready to 🍦 Backlog in .gov Product Board Jan 3, 2025
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Jan 6, 2025
@abroddrick
Copy link
Contributor

Removing refinement: I verified this is a real issue, and added a solution. Realistically, this should only happen if an analyst/superuser creates domain invitations for an existing user instead of user domain roles AND someone happens to visit this page before the "invited user" logs in to retrieve their invitations

@rachidatecs rachidatecs moved this from 🎯 Ready to 👀 In review in .gov Product Board Jan 7, 2025
dave-kennedy-ecs added a commit that referenced this issue Jan 8, 2025
#3228: DJA - new domain invitations are auto retrieved when user exists
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev issue is for the dev team
Projects
Status: ✅ Done
4 participants