Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Dependabot dependency updates #3065

Closed
2 tasks
abroddrick opened this issue Nov 12, 2024 · 6 comments · Fixed by #3221
Closed
2 tasks

Complete Dependabot dependency updates #3065

abroddrick opened this issue Nov 12, 2024 · 6 comments · Fixed by #3221
Assignees
Labels
dev issue is for the dev team fav Cameron's secret label housekeeping

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Nov 12, 2024

Issue description

In this repo's security tab, we have several updates that have come in for packages we use. Let's update these.

Some of these updates are for the same package; only the most recent upgrade needs to be applied. For instance, there are several django updates that call out updating to 4.2.14 and then later ones mention 4.2.15. We'll just go to the latest version.

Acceptance criteria

  • All security updates are applied to our code base; there should be 0 security updates in this tab when is completed.
  • If an update has already been applied to our system and is now non-applicable/ already resolved, just dismiss the alert as "inaccurate".

Additional context

No response

Links to other issues

No response

@abroddrick abroddrick added the dev issue is for the dev team label Nov 12, 2024
@abroddrick abroddrick changed the title Update Security dependencies Complete Dependabot dependency updates Nov 12, 2024
@abroddrick abroddrick moved this from 👶 New to 🍦 Backlog in .gov Product Board Dec 2, 2024
@PaulKuykendall PaulKuykendall added the fav Cameron's secret label label Dec 2, 2024
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Dec 4, 2024
@erinysong erinysong self-assigned this Dec 11, 2024
@erinysong erinysong moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Dec 11, 2024
@erinysong
Copy link
Contributor

erinysong commented Dec 12, 2024

@lizpearl
Can I get confirmation that we can dismiss the following warning:

And dismiss or not resolve the following warning:

@erinysong erinysong moved this from 🏗 In progress to 👀 In review in .gov Product Board Dec 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Dec 23, 2024
@h-m-f-t
Copy link
Member

h-m-f-t commented Dec 31, 2024

@erinysong it's unclear to me that the first acceptance criteria was met here. Can you explain why that initial link still has several vulnerable dependencies?

If sensitive, feel free to share elsewhere. cc: @lizpearl @abroddrick

@erinysong
Copy link
Contributor

erinysong commented Dec 31, 2024

thank you for the heads up @h-m-f-t. hm it looks duplicate warnings got created for each dependabot vulnerability. For example open warning 116 is identical to the resolved warning 117. Just cross checked with every open dependency and aside from the exceptions listed above, each one has an identical vulnerability warning marked as fixed.

I would lean resolving the duplicate vulnerability warnings that didn't get marked fixed since updating our dependencies should resolve them but also open to other suggestions

@h-m-f-t
Copy link
Member

h-m-f-t commented Dec 31, 2024

Thanks Erin! That makes sense.

@erinysong
Copy link
Contributor

update - I was wrong and the open issues were actually because the warnings were being caught in different files. Manually updating our Python dependencies should fix this and will do that right now. Thank you @lizpearl for finding the source!

@erinysong
Copy link
Contributor

Open Django warnings have been resolved in #3277 - thank you for bringing this to attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team fav Cameron's secret label housekeeping
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants