-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove expiration dates from Deleted
domains
#3095
Comments
In a working session with Gina, we decided to accept this ticket since its dependency has already been completed. This looks like relatively low effort, housekeeping. Sliding for sprint 61, since sprint 60 is already committed, and change status to |
Removed expiration dates for deleted domains on our staging database first and wanted to verify the results on our staging Domains table match the desired change. If so, we can do the same change on our stable data |
@erinysong, check out this link in the duplicate issue above ☝ . On a quick review, this looks like the same set of domains (it is the same number). |
Noted, thank you for bringing the duplicate issue to attention! Are we comfortable implementing the same change to our stable db then? It'd be the same queries run on stable instead of staging and just wanted to confirm before modifying stable data |
Queries and resulting data got looked over and ok'ed by @abroddrick - will run this on stable |
Expiration date removed from all deleted domains on stable |
Issue description
In #2823, we updated the process to remove domains from the registry, giving them a tombstone called the
Deleted
statue, and making it so newly-deleted domain have their expiration date removed. In this issue, we should remove the expiration date from domains that are currentlyDeleted
from stable(that were put there before we updated the process).Acceptance criteria
Deleted
state on stableAdditional context
no PR is needed, this can just be done by ssh-ing into stable and clearing the expiration date on those domains. (by clearing I mean doing domain.expiration_date = ""
See #2823 (comment) for more context.
Links to other issues
The text was updated successfully, but these errors were encountered: