Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expiration dates from Deleted domains #3095

Closed
1 task
h-m-f-t opened this issue Nov 18, 2024 · 6 comments
Closed
1 task

Remove expiration dates from Deleted domains #3095

h-m-f-t opened this issue Nov 18, 2024 · 6 comments
Assignees
Labels
dev issue is for the dev team

Comments

@h-m-f-t
Copy link
Member

h-m-f-t commented Nov 18, 2024

Issue description

In #2823, we updated the process to remove domains from the registry, giving them a tombstone called the Deleted statue, and making it so newly-deleted domain have their expiration date removed. In this issue, we should remove the expiration date from domains that are currently Deleted from stable(that were put there before we updated the process).

Acceptance criteria

  • Remove the expiration date from all domains that are currently in Deleted state on stable

Additional context

no PR is needed, this can just be done by ssh-ing into stable and clearing the expiration date on those domains. (by clearing I mean doing domain.expiration_date = ""
See #2823 (comment) for more context.

Links to other issues

@PaulKuykendall
Copy link

PaulKuykendall commented Dec 19, 2024

In a working session with Gina, we decided to accept this ticket since its dependency has already been completed. This looks like relatively low effort, housekeeping.

Sliding for sprint 61, since sprint 60 is already committed, and change status to Ready

@PaulKuykendall PaulKuykendall moved this from 👶 New to 🎯 Ready in .gov Product Board Dec 19, 2024
@PaulKuykendall PaulKuykendall added the dev issue is for the dev team label Dec 19, 2024
@erinysong erinysong self-assigned this Jan 7, 2025
@h-m-f-t h-m-f-t marked this as a duplicate of #3311 Jan 7, 2025
@erinysong erinysong moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Jan 8, 2025
@erinysong
Copy link
Contributor

erinysong commented Jan 8, 2025

Removed expiration dates for deleted domains on our staging database first and wanted to verify the results on our staging Domains table match the desired change. If so, we can do the same change on our stable data

@h-m-f-t
Copy link
Member Author

h-m-f-t commented Jan 8, 2025

@erinysong, check out this link in the duplicate issue above ☝ . On a quick review, this looks like the same set of domains (it is the same number).

@erinysong
Copy link
Contributor

Noted, thank you for bringing the duplicate issue to attention! Are we comfortable implementing the same change to our stable db then? It'd be the same queries run on stable instead of staging and just wanted to confirm before modifying stable data

@erinysong
Copy link
Contributor

Queries and resulting data got looked over and ok'ed by @abroddrick - will run this on stable

@erinysong
Copy link
Contributor

Expiration date removed from all deleted domains on stable

@erinysong erinysong moved this from 🏗 In progress to ✅ Done in .gov Product Board Jan 8, 2025
@erinysong erinysong closed this as completed by moving to ✅ Done in .gov Product Board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants