Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Profile feature flag and its references #2591

Closed
2 tasks
abroddrick opened this issue Aug 15, 2024 · 0 comments · Fixed by #2738
Closed
2 tasks

Remove Profile feature flag and its references #2591

abroddrick opened this issue Aug 15, 2024 · 0 comments · Fixed by #2738
Assignees

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Aug 15, 2024

Issue description

We have a lot of checks in our code checking for if the profile feature flag is on. That said this feature has been on for a while and we seem to have no complaints. Moving forward any issue we have we should just have a ticket for as a bug or new addition to the profile feature, but we do not need to turn off the feature entirely. Thus there is no longer a reason to keep the flag or it's references. We can clean that up.

Acceptance criteria

  • Remove all references to the profile feature flag including if checks
  • fix related unit tests and remove any obsolete ones if found

Additional context

Note: this really should be about a 2, but buffering this with 3 points as removing stuff can end in more unit tests breaking than we expect.

Links to other issues

blocked by #2162

@abroddrick abroddrick added the dev issue is for the dev team label Aug 15, 2024
@h-m-f-t h-m-f-t changed the title Remove Profile feature flag and it's references Remove Profile feature flag and its references Aug 16, 2024
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Aug 19, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Sep 4, 2024
@asaki222 asaki222 moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Sep 5, 2024
@asaki222 asaki222 moved this from 🏗 In progress to 👀 In review in .gov Product Board Sep 18, 2024
asaki222 added a commit that referenced this issue Sep 19, 2024
…ture-flag

#2591: Remove profile feature flag - [MEOWARD]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants