Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a duplicate email in "Domain managers" tab does not provide warning message #1405

Closed
vickyszuchin opened this issue Nov 27, 2023 · 3 comments · Fixed by #2710
Closed
Assignees
Labels
bug Something that isn't working as intended dev issue is for the dev team

Comments

@vickyszuchin
Copy link

Current Behavior

Task: manage a domain

When adding a new user in the "Domain managers" tab, if one adds an email that is already listed, it doesn't give a warning that you are adding an email that is already there. Just display a successful message.

Expected Behavior

Display a message to inform user that the email address is already listed.

Steps to Reproduce

When adding a new user in the "Domain managers" tab, if one adds an email that is already listed, it doesn't give a warning that you are adding an email that is already there. Just display a successful message.

Environment

No response

Additional Context

No response

Issue Links

No response

@vickyszuchin vickyszuchin added dev issue is for the dev team bug Something that isn't working as intended labels Nov 27, 2023
@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Nov 27, 2023
@PaulKuykendall PaulKuykendall added the later Not MVP label Nov 27, 2023
@vickyszuchin vickyszuchin removed the later Not MVP label Mar 12, 2024
@abroddrick
Copy link
Contributor

@Katherine-Osos would this require some content for a new warning message? Or think it's straight forward enough the dev can take a shot and the wording of the message can be refined during the design review?

@vickyszuchin
Copy link
Author

Added "refinement" label because of the question posted in comment for @Katherine-Osos.

@Katherine-Osos
Copy link
Contributor

Katherine-Osos commented Jul 23, 2024

@abroddrick There are two scenarios: 1) user invites someone who was already invited but has not logged in yet, i.e. they're still in the "invited" table. 2) user invites someone who is already a domain manager, i.e. they're in the "domain managers" table.

For scenario 1, show this message:

< email > has already been invited to this domain.

For scenario 2, show this message:

< email > is already a manager for this domain.

For design, use the warning status (yellow message bar) rather than success status (green message bar).

@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Aug 13, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Sep 4, 2024
@vickyszuchin vickyszuchin moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Sep 5, 2024
@asaki222 asaki222 moved this from 🏗 In progress to 👀 In review in .gov Product Board Sep 5, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev issue is for the dev team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants